Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Build Acceleration within the solution #9244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Aug 31, 2023

When Build Acceleration observes the Microsoft.VSSDK.BuildTools package in the project, it disables itself out of caution, as VSIX projects cannot be accelerated (they must call MSBuild in order to pack the VSIX).

In our solution we were adding this VSSDK package to every project, effectively disabling it entirely within the solution.

This change removes it from VisualStudio.props and adds it only to the VSIX project files themselves.

NOTE: This only impacts our team's development experience. This doesn't change anything for users of the project system in VS.

Microsoft Reviewers: Open in CodeFlow

When Build Acceleration observes the Microsoft.VSSDK.BuildTools package in the project, it disables itself out of caution, as VSIX projects cannot be accelerated (they must call MSBuild in order to pack the VSIX).

In our solution we were adding this VSSDK package to every project, effectively disabling it entirely within the solution.

This change removes it from VisualStudio.props and adds it only to the VSIX project files themselves.
@drewnoakes drewnoakes requested a review from a team as a code owner August 31, 2023 10:15
@drewnoakes
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tmeschter
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants